Skip to content

ps2 ee port #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Wolf3s wants to merge 23 commits into from
Closed

ps2 ee port #2

Wolf3s wants to merge 23 commits into from

Conversation

@Wolf3s
Copy link

@Wolf3s Wolf3s commented Sep 2, 2024

This pr superceeds #1
credits: @7dog123 for the first port.

derselbst and others added 22 commits December 29, 2023 13:06
@derselbst
Implement MSGS-style Drum Note Cut (FluidSynth#1199)
fa5173c 
Address FluidSynth#1196
@es20490446e
Make settings more pleasing, natural and subtler (FluidSynth#1287)
bd04f3f
@derselbst
Merge remote-tracking branch 'origin/release/2.3' into master
eabae3b
@derselbst
Fix signedness warning
652df6f
@derselbst
Fix ISO C warning
1b40e17
@mawe42 @derselbst
Stop the pipewire loop before destroying the stream
0901883 
Should fix FluidSynth#1305
@mawe42 @derselbst
Lock thread loop before destroying stream
0588096 
Better fix for FluidSynth#1305
@derselbst
Deprecate LASH support
56932cd 
Closes FluidSynth#1285
@derselbst
Make it a WARNING
a3b88cc
@derselbst
Fix XG drum bank selection logic
895f07d 
Fixes FluidSynth#1307
@derselbst
Merge branch 'release/2.3' into master
c5ed1af
@derselbst
Remove LASH
72cc6b3
@derselbst
Add FLUID_HOST_COMPILER cmake variable
619fc5c 
Fixes FluidSynth#1301
@derselbst
Merge branch 'release/2.3' into master
46ff5fa
@derselbst
Remove vcpkg CI badge from README
db86c36
@pedrolcl
add a new windows workflow based on msys2 (FluidSynth#1316)
e104532
@derselbst
Minor fixups for MSYS2 CI (FluidSynth#1317)
f78a9db
@cclauss
Keep GitHub Actions up to date with GitHub's Dependabot
abdd098 
Fixes the 16 software supply chain safety warnings at the bottom right of
https://github.com/FluidSynth/fluidsynth/actions/runs/8767406884

* [Keeping your actions up to date with Dependabot](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot)
* [Configuration options for the dependabot.yml file - package-ecosystem](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem)
@derselbst
Merge pull request FluidSynth#1318 from cclauss/patch-1
60ee179 
Keep GitHub Actions up to date with GitHub's Dependabot
@dependabot
Bump the github-actions group with 2 updates
7a4f8c7 
Bumps the github-actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [github/codeql-action](https://github.com/github/codeql-action).


Updates `actions/checkout` from 3 to 4
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

Updates `github/codeql-action` from 2 to 3
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
@derselbst
Merge pull request FluidSynth#1319 from FluidSynth/dependabot/github_…
cb8da1e 
…actions/github-actions-67979dcedc

Bump the github-actions group with 2 updates
@Wolf3s
Merge remote-tracking branch 'upstream/ee-sans_glib' into ps2-ee-sans…
1556942 
…-glib
@Wolf3s
Copy link
Author

Wolf3s commented Sep 2, 2024

cmake -S . -B build "-DCMAKE_TOOLCHAIN_FILE=${PS2DEV}/share/ps2dev.cmake" "-DCMAKE_INSTALL_PREFIX=${PS2SDK}/ports" -Denable=aufile=OFF -DBUILD_SHARED_LIBS=OFF -Denable-dbus=OFF -Denable-ipv6=OFF -Denable-jack=OFF -Denable-libinstpatch=OFF -Denable-libsndfile=OFF -Denable-midishare=OFF -Denable-network=ON -Denable-oss=OFF -Denable-dsound=OFF -Denable-wasapi=OFF -Denable-waveout=OFF -Denable-winmidi=OFF -Denable-sdl2=ON -Denable-pulseaudio=OFF -Denable-pipewire=OFF -Denable-readline=OFF -Denable-threads=ON -Denable-openmp=OFF

@fjtrujy
Copy link
Member

fjtrujy commented Oct 14, 2024

Can you please revert all the cosmetic changes and changes totally unrelated to the PS2 port?
it will help us to keep track of all the specific required changes.

@Wolf3s
Copy link
Author

Wolf3s commented Oct 14, 2024

Can you please revert all the cosmetic changes and changes totally unrelated to the PS2 port? it will help us to keep track of all the specific required changes.

Well then, I should deprecate this one and use sed patch on ps2sdk-ports for achive that.

@Wolf3s Wolf3s closed this Oct 14, 2024
@fjtrujy
Copy link
Member

fjtrujy commented Oct 14, 2024 •
edited
Loading

I was fine with the port, but we should keep the changes as small as possible.
I have the impression that tons of the changes we have here can be skipt with some specific boolean flags.
I don't think that having a sed on ps2sdk-ports will make things easier to follow honestly

@Wolf3s
Copy link
Author

Wolf3s commented Oct 14, 2024 •
edited
Loading

I was fine with the port, but we should keep the changes as small as possible. I have the impression that tons of the changes we have here can be skipt with some specific boolean flags. I don't think that having a sed on ps2sdk-ports will make things easier to follow honestly

Well it's only three stuff changed also there are some specific ones that needs to open a PR to remove inside like glib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Wolf3s @fjtrujy @derselbst @es20490446e @mawe42 @pedrolcl @cclauss